From: Claudio Cambra Date: Wed, 26 Mar 2025 16:53:42 +0000 (+0100) Subject: gui/macOS: Avoid crash from bad manager release X-Git-Tag: archive/raspbian/3.16.7-1_deb13u1+rpi1~1^2~12^2^2~62^2~2 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=90a66f5a5db3a8dba9af891e48a981d9efd9cfa0;p=nextcloud-desktop.git gui/macOS: Avoid crash from bad manager release Signed-off-by: Claudio Cambra --- diff --git a/src/gui/macOS/fileprovideritemmetadata_mac.mm b/src/gui/macOS/fileprovideritemmetadata_mac.mm index 8ff39979f..9a4e00c89 100644 --- a/src/gui/macOS/fileprovideritemmetadata_mac.mm +++ b/src/gui/macOS/fileprovideritemmetadata_mac.mm @@ -122,7 +122,7 @@ QString FileProviderItemMetadata::getUserVisiblePath() const __block QString returnPath = QObject::tr("Unknown"); NSFileProviderManager *const manager = FileProviderUtils::managerForDomainIdentifier(domainId); - if (manager == nil) { + if (manager == nil) { qCWarning(lcMacImplFileProviderItemMetadata) << "Null manager, cannot get item path"; return returnPath; } @@ -147,8 +147,6 @@ QString FileProviderItemMetadata::getUserVisiblePath() const dispatch_semaphore_wait(semaphore, DISPATCH_TIME_FOREVER); dispatch_release(semaphore); - [manager release]; - return returnPath; }